Ben comment on bithacks.h - bit hacks header file

Privacy Controls Software from ParetoLogic

Organizations which design systems are constrained to produce designs which are copies of the communication structures of these organizations. (For example, if you have four groups working on a compiler, you'll get a 4-pass compiler)

Damien Conway (Conway's Law)

I am doing a startup!

Cross-browser testing from your browser

I have written my first book!

Awk one-liners explained

You're viewing a comment by Ben and its responses.

Ben Permalink

January 14, 2010, 10:36

Hi,
your B_SET macros has a LP-64 portability problem.
Consider:

unsigned long_t x = 0;B_SET(x, 31);assert(x == (1ULThe assertion will fail because with ((x) |= (1#define BIT_MASK(x,n) ( ((__typeof((x)))1)I think, 1LL should also work on most platforms.Btw: Any naming suggestions for macros that do not modifytheir first argument but simply create a new value?Basically, |= vs. |

Reply to this comment